Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow JSON data substitutions client-side #1258

Merged
merged 17 commits into from
May 2, 2024
Merged

Allow JSON data substitutions client-side #1258

merged 17 commits into from
May 2, 2024

Conversation

tresf
Copy link
Contributor

@tresf tresf commented Apr 23, 2024 •
edited
Loading

TODO:

  • Add configurable property/flags:
    • Flag to disable feature (Done via security.substitutions.enable).
    • Flag to allow use without restrictions (e.g. copies, etc). (Done via security.substitutions.strict)
  • Cleanup unit tests
  • Add instance to PrintSocketClient
  • Add documentation

Closes #1256

@tresf tresf requested a review from akberenz April 27, 2024 00:33
@tresf tresf force-pushed the dimensions-override branch from 7ec8da6 to 98d72a0 Compare May 1, 2024 16:12
Vzor-
Vzor- reviewed May 2, 2024
View reviewed changes
src/qz/ws/substitutions/Type.java Show resolved Hide resolved
src/qz/ws/substitutions/Substitutions.java Outdated Show resolved Hide resolved
src/qz/ws/substitutions/Substitutions.java Outdated Show resolved Hide resolved
@tresf tresf merged commit 2ab63ba into master May 2, 2024
12 checks passed
@tresf tresf deleted the dimensions-override branch May 2, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vzor- Vzor- Vzor- approved these changes

@akberenz akberenz Awaiting requested review from akberenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support config, data substitutions client-side
2 participants
@tresf @Vzor-